Initial implementation of generic phasor dynamics app#359
Initial implementation of generic phasor dynamics app#359PhilipFackler wants to merge 2 commits intodevelopfrom
Conversation
…test with ThreeBusBasic case
pelesh
left a comment
pelesh
left a comment
There was a problem hiding this comment.
Looks good as is. A couple of things to address before we merge:
- Please add a README file explaining solver configuration input. A skeletal document is sufficient as I expect @abirchfield will want to add more features to that.
- Please make sure CI tests pass (see comment below).
| @@ -0,0 +1 @@ | |||
| add_subdirectory(PhasorDynamics) | |||
There was a problem hiding this comment.
The GridKit code should build without SUNDIALS. Consider adding this guard to prevent failing CI tests:
| add_subdirectory(PhasorDynamics) | |
| if(TARGET SUNDIALS::idas) | |
| add_subdirectory(PhasorDynamics) | |
| endif() |
| WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}) | ||
|
|
||
| add_test(NAME ThreeBusBasic_using_app | ||
| COMMAND PDSim ${CMAKE_CURRENT_SOURCE_DIR}/ThreeBusBasic.study.json |
There was a problem hiding this comment.
Perhaps call it solver or config?
| COMMAND PDSim ${CMAKE_CURRENT_SOURCE_DIR}/ThreeBusBasic.study.json | |
| COMMAND PDSim ${CMAKE_CURRENT_SOURCE_DIR}/ThreeBusBasic.solver.json |
Similarly, we could rename ThreeBusBasic.json --> ThreeBusBasic.case.json to be more self-explanatory to the domain folk.
|
This is a great addition and an important step, so I had a lot of feedback. I had enough edits that I opened PR #363 on this branch (apologies if I did that incorrectly). I added various safety checks and extended the |
Thanks for the feedback @lukelowry, I responded in your PR. |
3 participants
Description
Please describe the issue that is addressed (bug, new feature,
documentation, enhancement, etc.). Please also include relevant motivation and
context. List any dependencies that are required for this change.
See #349
Proposed changes
Describe how your changes here address the issue and why the proposed changes
should be accepted.
Checklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask. We're here
to help! This is simply a reminder of what we are going to look for before
merging your code.
-Wall -Wpedantic -Wconversion -Wextra.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining
why you chose the solution you did and what alternatives you considered, etc...